Last boolean attr add#17
Open
MurakamiKennzo wants to merge 2 commits intorayd:masterfrom
MurakamiKennzo:last-boolean-attr-add
Open
Last boolean attr add#17MurakamiKennzo wants to merge 2 commits intorayd:masterfrom MurakamiKennzo:last-boolean-attr-add
MurakamiKennzo wants to merge 2 commits intorayd:masterfrom
MurakamiKennzo:last-boolean-attr-add
Conversation
Author
|
HI, @rayd I am happy you can reply me , but since I am greener here and can you tell me how to find failed check? and what should I do ? thanks. |
Owner
|
Hi @MurakamiKennzo, thanks for the fix! Would you mind adding a test to verify the fix? I think the Travis CI failure is because I've configured it incorrectly. I will try to get this fixed. |
Author
|
yes, i try to add test similar as your test code in parse-tag.js. but I cannot run npm test. since I am unfamiliar with zuul,. so I cannot fix it and push code. it seems node deprecated api bug and configured incorrectly caused. waiting.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #15